Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bounds check apple-clang-14 test #896

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

jarzec
Copy link
Contributor

@jarzec jarzec commented Dec 20, 2023

Update another MacOS test missed in a recent PR. The issue was spotted thanks to the tools from #897.

@hsutter
Copy link
Owner

hsutter commented Dec 20, 2023

Thanks! For this and for the description with this example of how the test flow works.

The reason the Apple Clang test was not updated in my PR that committed the diagnostic message change is because that's the only one of the checked-in tests I can't run locally on my machine and then commit as part of the PR.

Re CRLF/LF: In just the past couple of weeks I've noticed a few times when I'm checking regression test on a commit and many of the files have only CRLF/LF differences. This seems to be a new thing and I haven't investigated the root cause. I vaguely recall that back when I started cppfront I looked at autocrlf but no setting was perfect -- could the setting be improved?

@hsutter hsutter merged commit bb819d1 into hsutter:main Dec 20, 2023
@jarzec jarzec deleted the update-apple-clang-14-test branch December 20, 2023 18:29
@jarzec
Copy link
Contributor Author

jarzec commented Dec 20, 2023

Thanks! For this and for the description with this example of how the test flow works.

The reason the Apple Clang test was not updated in my PR that committed the diagnostic message change is because that's the only one of the checked-in tests I can't run locally on my machine and then commit as part of the PR.

Re CRLF/LF: In just the past couple of weeks I've noticed a few times when I'm checking regression test on a commit and many of the files have only CRLF/LF differences. This seems to be a new thing and I haven't investigated the root cause. I vaguely recall that back when I started cppfront I looked at autocrlf but no setting was perfect -- could the setting be improved?

Do you have a preference as to which one you would prefer CRLF or LF? I could create a PR that would enforce the autocrlf option for everyone an normalize the repo to the chosen option.

@hsutter
Copy link
Owner

hsutter commented Dec 20, 2023

I always do my development and regressions test on Windows, so CRLF would work best for me if it doesn't impact others too much to optimize for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants