Address #346 and shrink attrdict.c. #370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… side effects to my changes, I'm starting over with this. Comments in the PR thread. This commit reduces the size of attrdict.c while causing only a single errout regression that is justified.
Bump version to 5.1.38
balthisar
added a commit
that referenced
this pull request
Feb 16, 2016
Address #346 and shrink attrdict.c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the previous effort #350 grew too fast and there was a LOT of side effects to my changes, I'm starting over with this, which addresses #346 (finally) and causes only a single regression.
This commit reduces the size of
attrdict.cwhile causing only a single errout regression that is justified.Specifically case 1055398 is expecting to see
line 8 column 1 - Warning: <font> proprietary attribute "onload"in the error output. However as this is not a propriety attribute, it's correct that it should not be reported as one. However there are certain HTML versions thatonloadcan't be used in; that will be the focus of _phase2.I will update test case 1055398 with the new output, and unless there are any negative comments, I'll roll it in with #368 (or let @geoffmcl do it). I would suggest combining them for a single version bump.