-
Notifications
You must be signed in to change notification settings - Fork 38
Check if a lightbulb has fullcolorsupport #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4a96bcb
to
09d7e4a
Compare
mib1185
requested changes
Jan 19, 2025
mib1185
reviewed
Jan 25, 2025
mib1185
approved these changes
Jan 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx @flabbamann 👍
there are conflicts, please resolve them before we can merge this PR |
Co-authored-by: Michael <35783820+mib1185@users.noreply.github.com>
cd65576
to
2ffa257
Compare
Hm, Githubs new merge experience shows no conflicts, the classic merge experience does... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
fullcolorsupport
is set, we can usesetunmappedcolor
for free color selection. This was not documented at the time I implemented the free color selection.