Skip to content

Conversation

hthiery
Copy link
Owner

@hthiery hthiery commented Jan 19, 2025

There are devices that can return empty values for these fields. To avoid crashing (throwing uncatched exception) we catch these.

There are devices that can return empty values for these fields. To
avoid crashing (throwing uncatched exception) we catch these.

Fixes: issue #109

Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
@hthiery hthiery force-pushed the feature/powermeter-fix branch from 0d59890 to 2388c5c Compare January 19, 2025 14:23
@coveralls
Copy link

coveralls commented Jan 19, 2025

Coverage Status

coverage: 95.778% (+0.03%) from 95.751%
when pulling f661bdd on feature/powermeter-fix
into c2d065e on master.

The missing values for energy and power are now also checked.

Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
@hthiery hthiery force-pushed the feature/powermeter-fix branch from 2b6b189 to f661bdd Compare January 20, 2025 10:11
Copy link
Collaborator

@mib1185 mib1185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hthiery hthiery merged commit 869fd9c into master Jan 20, 2025
25 checks passed
@mib1185 mib1185 deleted the feature/powermeter-fix branch January 25, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Powermeter values can be empty
3 participants