Skip to content

Conversation

mib1185
Copy link
Collaborator

@mib1185 mib1185 commented Feb 20, 2025

(plain - 16) / 2 + 8 - this subtracts 16 from the value, halves it and then adds the half of of 16 again - so just halve the value is the same

int(16 + ((float(temperature) - 8) * 2)) - this subtracts 8 from the value, doubles it and add the double of 8 again - so just double the value is the same

temp > max(range(16, 56)): this was already true for temp=56 instead of a temp higher than 56

@coveralls
Copy link

Coverage Status

coverage: 96.856%. remained the same
when pulling 067d1a5 on mib1185:simplify-target_temp-calculations-and-fix-set-max-target-temp
into 39d7510 on hthiery:master.

@mib1185 mib1185 merged commit 6a739e6 into hthiery:master Feb 21, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants