fix docstyle and add test to actions #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
./pyfritzhome/fritzhome.py:351 in public method `has_templates`:
D400: First line should end with a period (not 's')
Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
./pyfritzhome/fritzhome.py:395 in public method `apply_template`:
D401: First line should be in imperative mood ('Applie', not 'Applies')
Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
./pyfritzhome/errors.py:5 in public method `__str__`:
D105: Missing docstring in magic method
./pyfritzhome/__init__.py:1 at module level:
D104: Missing docstring in public package
./pyfritzhome/devicetypes/__init__.py:1 at module level:
D104: Missing docstring in public package
./tests/__init__.py:1 at module level:
D104: Missing docstring in public package
Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
Only check files under the pyfritzhome directory. Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
./pyfritzhome/fritzhomedevice.py:30 in public method `__init__`:
D102: Missing docstring in public method
./pyfritzhome/fritzhome.py:28 in public method `__init__`:
D102: Missing docstring in public method
./pyfritzhome/fritzhome.py:127 in public method `update_devices`:
D102: Missing docstring in public method
./pyfritzhome/fritzhome.py:340 in public method `set_blind_open`:
D102: Missing docstring in public method
./pyfritzhome/fritzhome.py:343 in public method `set_blind_close`:
D102: Missing docstring in public method
./pyfritzhome/fritzhome.py:346 in public method `set_blind_stop`:
D102: Missing docstring in public method
./pyfritzhome/fritzhome.py:360 in public method `update_templates`:
D102: Missing docstring in public method
./pyfritzhome/devicetypes/fritzhomedevicebutton.py:43 in public method `get_button_by_ain`:
D102: Missing docstring in public method
./pyfritzhome/devicetypes/fritzhomedevicebutton.py:55 in public method `__init__`:
D102: Missing docstring in public method
./pyfritzhome/devicetypes/fritzhomedevicebutton.py:69 in public method `get_node_value`:
D102: Missing docstring in public method
./pyfritzhome/devicetypes/fritzhomedevicebutton.py:72 in public method `get_node_value_as_int`:
D102: Missing docstring in public method
./pyfritzhome/devicetypes/fritzhomeentitybase.py:21 in public method `__init__`:
D102: Missing docstring in public method
./pyfritzhome/devicetypes/fritzhomeentitybase.py:46 in public method `get_node_value`:
D102: Missing docstring in public method
./pyfritzhome/devicetypes/fritzhomeentitybase.py:49 in public method `get_node_value_as_int`:
D102: Missing docstring in public method
./pyfritzhome/devicetypes/fritzhomeentitybase.py:52 in public method `get_node_value_as_int_as_bool`:
D102: Missing docstring in public method
./pyfritzhome/devicetypes/fritzhomeentitybase.py:55 in public method `get_temp_from_node`:
D102: Missing docstring in public method
./pyfritzhome/devicetypes/fritzhomedeviceblind.py:55 in public method `get_level`:
D102: Missing docstring in public method
./pyfritzhome/devicetypes/fritzhomedeviceblind.py:58 in public method `get_level_percentage`:
D102: Missing docstring in public method
./pyfritzhome/devicetypes/fritzhomedeviceblind.py:61 in public method `set_level`:
D102: Missing docstring in public method
./pyfritzhome/devicetypes/fritzhomedeviceblind.py:64 in public method `set_level_percentage`:
D102: Missing docstring in public method
./pyfritzhome/devicetypes/fritzhomedeviceblind.py:67 in public method `set_blind_open`:
D102: Missing docstring in public method
./pyfritzhome/devicetypes/fritzhomedeviceblind.py:70 in public method `set_blind_close`:
D102: Missing docstring in public method
./pyfritzhome/devicetypes/fritzhomedeviceblind.py:73 in public method `set_blind_stop`:
D102: Missing docstring in public method
./tests/helper.py:10 in public method `response`:
D102: Missing docstring in public method
Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
./pyfritzhome/errors.py:1 in public class `LoginError`:
D101: Missing docstring in public class
./pyfritzhome/errors.py:11 in public class `InvalidError`:
D101: Missing docstring in public class
Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
./setup.py:1 at module level:
D100: Missing docstring in public module
./pyfritzhome/fritzhomedevice.py:1 at module level:
D100: Missing docstring in public module
./pyfritzhome/cli.py:1 at module level:
D100: Missing docstring in public module
./pyfritzhome/fritzhome.py:1 at module level:
D100: Missing docstring in public module
./pyfritzhome/errors.py:1 at module level:
D100: Missing docstring in public module
Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.