-
Notifications
You must be signed in to change notification settings - Fork 299
Parser changes for the new ruby model #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Critic review: https://critic.hoppipolla.co.uk/r/457 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
There are tests in html5lib/html5lib-tests#27. |
html5lib/html5parser.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you'll need to change this line to reflect recent bug fix at W3C bug 26074.
Update parser to follow HTML5 spec change at: w3c/html@c61397b
Rp should not auto close rtc.
So, the tests in html5lib/html5lib-tests#27 have now landed; I guess this might be ready for acceptance? |
We need to do something about having tests pass before anything else lands (expected failures or something need to be implemented given we won't always be in-sync with html5lib-tests…), meh. :( |
hm, not sure why it fails so many, maybe I don't understand how to read the result, but one thing I can tell is that one of the failures is because a pull request for test expectation file update is still pending. |
Most of them are broken because |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is wrong. You need two distinct groups. Or you need to also branch the self.tree.openElements[-1].name != "ruby"
line further. What you're doing now doesn't match other implementations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure that this PR is up to date with the more recent changes to the spec anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It isn't.
I'm just going to close this as outdated and deal with this with the larger spec update. |
As per http://darobin.github.io/html-ruby/. This change is being landed in the W3C specification, apply with caution.