Skip to content

Conversation

sigmundch
Copy link
Contributor

No description provided.

@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/844

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@gsnedders
Copy link
Member

@sigmundch Given dicts have no order, how is there any issue here?

@sigmundch
Copy link
Contributor Author

Note that this swaps which key is associated with each value (e.g. expectedName should be node.name rather than body). So if you have:

<div></span>

The error used to say:
Unexpected end tag (div). Missing end tag (span).

Now the error will say:
Unexpected end tag (span). Missing end tag (div).

@gsnedders
Copy link
Member

Oh. I can't read. Duh. :)

@gsnedders
Copy link
Member

rebased & landed as 3ebdd8b

@gsnedders gsnedders closed this Dec 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants