Double-escape a troublesome tokenizer test #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Critic review: https://critic.hoppipolla.co.uk/r/231 This is an external review system which you may optionally use for the code review of your pull request. |
|
Also what is this hoppipolla-critic-bot stuff? |
gsnedders
added a commit
that referenced
this pull request
Aug 31, 2013
Double-escape a troublesome tokenizer test. U+FEFF apparently doesn't decode nicely from JSON under Ruby 2.0 and Obj-C/Cocoa.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had issues with this test using the stock Ruby (2.0) and Objective-C (NSJSONSerialization) JSON decoders. And I don't think this change will affect anyone who properly implements the
doubleEscapedvalue.