Expect <menuitem> to parse like an unknown element #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iabudiab
added a commit
to iabudiab/HTMLKit
that referenced
this pull request
Feb 11, 2017
This reverses the parser change introduced in commit: b0bad50 The list of special elements is not reverted The change was reverted in the spec: whatwg/html#2319 and the html5lib-tests: html5lib/html5lib-tests#88
craigbarnes
added a commit
to craigbarnes/lua-gumbo
that referenced
this pull request
May 10, 2018
It has been removed from the whatwg HTML spec and the html5lib tests now expect it to be handled as an unknown element. See also: * https://developer.mozilla.org/en-US/docs/Web/HTML/Element/menuitem * whatwg/html#2319 * html5lib/html5lib-tests#88 All html5lib tree-construction tests are now passing: Ran 1689 tests in 0.15s Passed: 1689 Failed: 0 Skipped: 0
stevecheckoway
pushed a commit
to stevecheckoway/nokogumbo
that referenced
this pull request
Aug 19, 2018
It has been removed from the whatwg HTML spec and the html5lib tests now expect it to be handled as an unknown element. See also: * https://developer.mozilla.org/en-US/docs/Web/HTML/Element/menuitem * whatwg/html#2319 * html5lib/html5lib-tests#88 All html5lib tree-construction tests are now passing: Ran 1689 tests in 0.15s Passed: 1689 Failed: 0 Skipped: 0
stevecheckoway
pushed a commit
to rubys/nokogumbo
that referenced
this pull request
Aug 22, 2018
It has been removed from the whatwg HTML spec and the html5lib tests now expect it to be handled as an unknown element. See also: * https://developer.mozilla.org/en-US/docs/Web/HTML/Element/menuitem * whatwg/html#2319 * html5lib/html5lib-tests#88 All html5lib tree-construction tests are now passing: Ran 1689 tests in 0.15s Passed: 1689 Failed: 0 Skipped: 0
chozekun
pushed a commit
to chozekun/gumbo-parser
that referenced
this pull request
Dec 13, 2018
It has been removed from the whatwg HTML spec and the html5lib tests now expect it to be handled as an unknown element. See also: * https://developer.mozilla.org/en-US/docs/Web/HTML/Element/menuitem * whatwg/html#2319 * html5lib/html5lib-tests#88 All html5lib tree-construction tests are now passing: Ran 1689 tests in 0.15s Passed: 1689 Failed: 0 Skipped: 0
chozekun
pushed a commit
to chozekun/gumbo-parser
that referenced
this pull request
Dec 16, 2018
It has been removed from the whatwg HTML spec and the html5lib tests now expect it to be handled as an unknown element. See also: * https://developer.mozilla.org/en-US/docs/Web/HTML/Element/menuitem * whatwg/html#2319 * html5lib/html5lib-tests#88 All html5lib tree-construction tests are now passing: Ran 1689 tests in 0.15s Passed: 1689 Failed: 0 Skipped: 0
chozekun
pushed a commit
to chozekun/gumbo-parser
that referenced
this pull request
Dec 16, 2018
It has been removed from the whatwg HTML spec and the html5lib tests now expect it to be handled as an unknown element. See also: * https://developer.mozilla.org/en-US/docs/Web/HTML/Element/menuitem * whatwg/html#2319 * html5lib/html5lib-tests#88 All html5lib tree-construction tests are now passing: Ran 1689 tests in 0.15s Passed: 1689 Failed: 0 Skipped: 0
flavorjones
pushed a commit
to sparklemotion/nokogiri
that referenced
this pull request
Apr 7, 2021
It has been removed from the whatwg HTML spec and the html5lib tests now expect it to be handled as an unknown element. See also: * https://developer.mozilla.org/en-US/docs/Web/HTML/Element/menuitem * whatwg/html#2319 * html5lib/html5lib-tests#88 All html5lib tree-construction tests are now passing: Ran 1689 tests in 0.15s Passed: 1689 Failed: 0 Skipped: 0
txgk
added a commit
to gumbo-parser/gumbo-parser
that referenced
this pull request
Aug 26, 2025
this lets us pass 13 more tests from html5lib-tests whatwg/html#2319 html5lib/html5lib-tests#88 rubys/nokogumbo@4af5691
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows whatwg/html#2319.