fix: fix url repo pkg #413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shinigami92
suggested changes
May 24, 2020
package.json
Outdated
| "repository": { | ||
| "type": "git", | ||
| "url": "https://github.com/htmlhint/HTMLHint" | ||
| "url": "git+https://github.com//htmlhint/HTMLHint.git" |
There was a problem hiding this comment.
I don't think we need the // before htmlhint
When I look into other repos like here, there is no double /
There was a problem hiding this comment.
Also, according to the NPM docs, we could probably use a simpler syntax:
"repository": "npm/npm"
or
"repository": "github:user/repo"
if we want to be more explicit.
There was a problem hiding this comment.
I don't know how well this works in terms of package.json: "click on link"
There was a problem hiding this comment.
Before Semantic Release uses that link, I prefer to keep it consistent with all repos.
Shinigami92
approved these changes
May 25, 2020
thedaviddias
pushed a commit
that referenced
this pull request
May 30, 2020
## [0.13.1-beta.1](v0.13.0...v0.13.1-beta.1) (2020-05-30) ### Bug Fixes * add missing branches to action release ([#425](#425)) ([62c2f3c](62c2f3c)) * add missing plugins for docusaurus ([#402](#402)) ([d9ef347](d9ef347)) * correctly call hint queue drain ([#409](#409)) ([7b63cb2](7b63cb2)) * dupplicate ga ([#407](#407)) ([506f25a](506f25a)) * eslint fix ([820ff8f](820ff8f)) * fix url repo pkg ([#413](#413)) ([b7f5786](b7f5786)) * **attr-no-unnecessary-whitespace:** fix when equals symbol in value ([#405](#405)) ([fe4f3c6](fe4f3c6)) * github token ([18441f6](18441f6))
|
🎉 This PR is included in version 0.13.1-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
thedaviddias
pushed a commit
that referenced
this pull request
May 31, 2020
## [0.13.1](v0.13.0...v0.13.1) (2020-05-31) ### Bug Fixes * add missing branches to action release ([#425](#425)) ([62c2f3c](62c2f3c)) * add missing plugins for docusaurus ([#402](#402)) ([d9ef347](d9ef347)) * correctly call hint queue drain ([#409](#409)) ([7b63cb2](7b63cb2)) * dupplicate ga ([#407](#407)) ([506f25a](506f25a)) * eslint fix ([820ff8f](820ff8f)) * fix url repo pkg ([#413](#413)) ([b7f5786](b7f5786)) * github token ([18441f6](18441f6)) * remove unused dependency esm ([#430](#430)) ([7e8429d](7e8429d)) * **attr-no-unnecessary-whitespace:** fix when equals symbol in value ([#405](#405)) ([fe4f3c6](fe4f3c6))
|
🎉 This PR is included in version 0.13.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
Wrong URI for repo in package JSON