Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Unexpected behavior of the html lang require rule #655

Conversation

baleyko
Copy link
Contributor

@baleyko baleyko commented Jun 11, 2021

This PR made to resolve the next two issues:

  1. html-lang-require rule show false result in valid cases (html-lang-require reports lots of false positives #653)
    reason: because of reusing of the RegExp object which keeps the state after previous check
  2. html-lang-require rule should not be applied to non HTML tag (html-lang-require should allow just language (not require region) #652)

@baleyko baleyko changed the title Unexpected behavior of the html lang require rule fix: Unexpected behavior of the html lang require rule Jun 11, 2021
Copy link
Member

@thedaviddias thedaviddias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @baleyko for adding the fixes and tests.

@thedaviddias thedaviddias merged commit 068645e into htmlhint:master Jun 11, 2021
thedaviddias pushed a commit that referenced this pull request Jun 11, 2021
## [0.15.1](v0.15.0...v0.15.1) (2021-06-11)

### Bug Fixes

* Unexpected behavior of the html lang require rule ([#655](#655)) ([068645e](068645e))
@thedaviddias
Copy link
Member

🎉 This PR is included in version 0.15.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@thedaviddias thedaviddias linked an issue Jun 11, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

html-lang-require reports lots of false positives
2 participants