Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove base resolve #269

Merged
merged 1 commit into from
Aug 26, 2018
Merged

remove base resolve #269

merged 1 commit into from
Aug 26, 2018

Conversation

thedaviddias
Copy link
Member

Fixes: #247

  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.

Short description of what this resolves:

The previous fix has broken the use of HTMLHint on Mac OSX.

Proposed changes:

  • The duplication of path.resolve broked the correct path.

@thedaviddias thedaviddias added bug Functionality that does not work as intended/expected #status: accepted labels Aug 26, 2018
@thedaviddias thedaviddias merged commit 8fd7e09 into develop Aug 26, 2018
@thedaviddias thedaviddias deleted the feature/feature/#247-fixed-search-mac-error branch August 26, 2018 18:56
thedaviddias added a commit that referenced this pull request Sep 3, 2018
@thedaviddias
fix: remove base resolve (#269)
e1584f5
thedaviddias added a commit that referenced this pull request Sep 3, 2018
@thedaviddias
fix: remove base resolve (#269)
3227c30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Functionality that does not work as intended/expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thedaviddias