-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSL Certificate Checking and Grammar Fixes #479
Conversation
changed caching policy algorithm; fixed grammar in testing Signed-off-by: Danny Dalton <daltond2@hawkmail.newpaltz.edu>
Yes, I can change the wording and re-submit the pull request if you need me to, or do it in a different PR. |
No need to submit a new request, you can just make the changes here! There are a few merge conflicts as well, so you'll want to merge master. |
Changed `could not stat` to `could not find`.
Fixed merge conflicts and wording. |
Meant to update README to be tabular in a separate pull request. Eh, lemme know what you think |
Yeah the readme changes are significant and separate from the cert/key checking, so that should be its own PR |
Sorry about that! I undid those changes, I'm still getting used to Git honestly. Should've honestly made a new branch on my end for it |
No problem! |
I squashed because of the revert commits; better to have that all together. Thanks @dandalton1! |
bin/http-server
to have aligned tabs!!
)null
, in casenull
is suppliedtrue
should be aBoolean
instead of aString
Fixes #135