Skip to content

Conversation

Volune
Copy link
Contributor

@Volune Volune commented May 24, 2016

One test "should emit open and close events when socket.io client connects and disconnects" is broken since socket.io-client upgraded to 1.4.6 (upgrading its dependency engine.io-client to 1.6.9), because of a new default value in commit: socketio/engine.io-client@7fa16d5

This pull request force the value of rejectUnauthorized to null (like before upgrade) to fix the test.

@jcrugzz
Copy link
Contributor

jcrugzz commented May 25, 2016

Thanks so much! 👍

@jcrugzz jcrugzz merged commit 3e96636 into http-party:master May 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants