Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overwriting of global options #1074

Merged
merged 1 commit into from Jan 3, 2018
Merged

Conversation

georgiyordanov
Copy link
Contributor

@georgiyordanov georgiyordanov commented Sep 30, 2016

Global options are being overwritten from proxy.web(req, res, opts), which breaks some more complex scenarios like proxying to multiple servers with different options.

This is essentially the same as #833 but with a test case.

@efokschaner
Copy link

efokschaner commented Jan 16, 2017

@jcrugzz or anyone else, any reason not to get this merged?

@efokschaner
Copy link

efokschaner commented Feb 12, 2017

Bump for great justice? @jcrugzz

@schipiga
Copy link

schipiga commented Nov 10, 2017

let to merge this cool patch

@efokschaner
Copy link

efokschaner commented Jan 1, 2018

Had to work around this again today. Can we get a yes/no on this PR finally please? Don't leave us hanging @jcrugzz :)

@jcrugzz jcrugzz merged commit 8127575 into http-party:master Jan 3, 2018
@schipiga
Copy link

schipiga commented Jan 3, 2018

💪

@juliangruber
Copy link

juliangruber commented Mar 20, 2018

can we release this?

This was referenced Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants