Fix overwriting of global options #1074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgiyordanov
force-pushed
the
master
branch
from
17c88e7 to
006eb24
Compare
|
@jcrugzz or anyone else, any reason not to get this merged? |
|
Bump for great justice? @jcrugzz |
|
let to merge this cool patch |
|
Had to work around this again today. Can we get a yes/no on this PR finally please? Don't leave us hanging @jcrugzz :) |
|
💪 |
|
can we release this? |
This was referenced Mar 11, 2021
Open
This was referenced Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Global options are being overwritten from
proxy.web(req, res, opts), which breaks some more complex scenarios like proxying to multiple servers with different options.This is essentially the same as #833 but with a test case.