Skip to content

Fix issue where front-end is HTTPS, back-end is HTTP, and server issues a redirect. #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 14, 2011
Merged

Fix issue where front-end is HTTPS, back-end is HTTP, and server issues a redirect. #165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
553e7fb
Modified the ad-hoc proxy lookup to use _getKey(), rather than the
elfsternberg Nov 29, 2011
411bb51
Fix issue where front-end is HTTPS, back-end is HTTP, and server issu…
elfsternberg Nov 29, 2011
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions lib/node-http-proxy/http-proxy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,15 @@ HttpProxy.prototype.proxyRequest = function (req, res, buffer) {
delete response.headers['transfer-encoding'];
}

if ((response.statusCode === 301) || (response.statusCode === 302)) {
if (self.source.https && !self.target.https) {
response.headers.location = response.headers.location.replace(/^http\:/, 'https:');
}
if (self.target.https && !self.source.https) {
response.headers.location = response.headers.location.replace(/^https\:/, 'http:');
}
}

// Set the headers of the client response
res.writeHead(response.statusCode, response.headers);

Expand Down
8 changes: 4 additions & 4 deletions lib/node-http-proxy/routing-proxy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,8 +180,8 @@ RoutingProxy.prototype.proxyRequest = function (req, res, options) {
options.host = location.host;
}

var key = options.host + ':' + options.port,
proxy;
var key = this._getKey(options),
proxy;

if (!this.proxies[key]) {
this.add(options);
Expand Down Expand Up @@ -218,8 +218,8 @@ RoutingProxy.prototype.proxyWebSocketRequest = function (req, socket, head, opti
options.host = location.host;
}

var key = options.host + ':' + options.port,
proxy;
var key = this._getKey(options),
proxy;

if (!this.proxies[key]) {
this.add(options);
Expand Down