Skip to content

async-h1 update for http-types 2.0.0 #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 22, 2020
Merged

async-h1 update for http-types 2.0.0 #105

merged 4 commits into from
May 22, 2020

Conversation

jbr
Copy link
Member

@jbr jbr commented Apr 27, 2020 •
edited
Loading

No description provided.

@jbr jbr mentioned this pull request Apr 27, 2020
Closed
@jbr jbr mentioned this pull request May 7, 2020
Closed
@jbr jbr marked this pull request as ready for review May 7, 2020 23:59
@jbr jbr force-pushed the update-http-types branch 2 times, most recently from a0245f7 to c339173 Compare May 8, 2020 23:58
@jbr jbr force-pushed the update-http-types branch 3 times, most recently from 81ecc6f to 446c8d9 Compare May 18, 2020 21:53
@jbr jbr force-pushed the update-http-types branch from 446c8d9 to 9fd5ea0 Compare May 18, 2020 22:02
@jbr
Copy link
Member Author

jbr commented May 18, 2020

@yoshuawuyts Aside from the fact that this is building against github master, this is ready for review

yoshuawuyts
yoshuawuyts approved these changes May 18, 2020
View reviewed changes
Copy link
Member

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good; left a few nits but excited for this!

@jbr jbr force-pushed the update-http-types branch from 978e000 to d26570a Compare May 18, 2020 22:59
@jbr jbr mentioned this pull request May 19, 2020
Merged
@jbr jbr force-pushed the update-http-types branch from 5eb88f7 to c3106b7 Compare May 20, 2020 03:11
@jbr jbr changed the title update http-types to master async-h1 update for http-types 2.0 May 22, 2020
@jbr jbr changed the title async-h1 update for http-types 2.0 async-h1 update for http-types 2.0.0 May 22, 2020
@yoshuawuyts yoshuawuyts merged commit 7a7b358 into http-rs:master May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshuawuyts yoshuawuyts yoshuawuyts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbr @yoshuawuyts