remove url crate re-export #243
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i like it! looks like it needs a couple of docs updates though |
the url crate is part of http-types; there is no need to re-export the full submodule from here
yoshuawuyts
force-pushed
the
no-url-re-export
branch
from
9354422
to
1c4d662
Compare
This was referenced Oct 3, 2020
Merged
Fishrock123
added a commit
that referenced
this pull request
Oct 5, 2020
Remove url direct dep (rebase and extension of #243)
|
superseded by #249 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The url crate is part of http-types; there is no need to re-export the full submodule from here. This cleans up the module index slightly. Thanks!