feat: add per-request middleware #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an optional middleware stack to `Request`, allowing `RequestBuilder` and one-off requests to have middleware added onto them, but also allows one-off requests with middleware to have the middleware stack be appended to client middleware for just that request.
yoshuawuyts
approved these changes
Nov 27, 2020
| @@ -177,6 +177,8 @@ impl Client { | |||
|
|
|||
| /// Send a `Request` using this client. | |||
| /// | |||
| /// Client middleware is run before per-request middleware. | |||
There was a problem hiding this comment.
nice; I think this clarification will be helpful
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think Tide & Surf's focus on ergonomics predicates this should happen, even if it's not the most efficient.
Were it for efficiency alone we would not have the top-level http-verb quick methods.
Hopefully the notice in the docs will put people in the correct direction for most cases.
This adds an optional middleware stack to
Request, allowingRequestBuilderand one-off requests to have middleware added onto them, but also allows one-off requests with middleware to have the middleware stack be appended to client middleware for just that request.Closes #261