-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request is fired to packages.httpie.io on every invocation of http
#1527
Comments
Thanks for the report. This is supposed to happen infrequently. Will fix. |
Still happening. Very annoying testing a proxy server getting an extra request on every request. |
Still happening on the latest version (3.2.2). |
I tried to reproduce but without success. Can, everyone in this thread, post the debug output so that we can establish the common factor? |
I can reproduce this still on |
@Ousret running mitmproxy listening on port 8080. Running Running the same command twice results in No matter what kind of request I make with HTTPie, it always fires off a check to Hopefully this is useful. |
Found the origin of this situation. A fix is available in #1531 |
Can you test the patch and report back? If it solved your issue or not. |
@Ousret well, it's certainly different. It seems that HTTPie is still issuing the requests, but now doesn't trust the proxy's cert (even with |
HTTPie initially set verif=False (v3.x) for fetching latest versions information from the server, the given PR let it (cert verif) by default. If you don't use mitmproxy and the request succeed, it will stop doing it. You can try to install the patch again, it should be OK now. |
Yup, seems to work! I tested various orderings of using proxy/not using proxy (in a Docker container so different tests did not influence each other) and it no longer does the update check every time. Thank you for the hard work! Now just have to wait for #1531 to land... |
A request is fired to
packages.httpie.io
on every invocation ofhttp
. Not sure if this related to update notifications (#1136). If so, then it seems overkill to check for updates on every single invocation.You can see and/or block this request using something like opensnitch (linux) or littlesnitch (mac).
Checklist
Minimal reproduction code and steps
http example.com
opensnitch
/littlesnitch
(links above) to view request topackages.httpie.io
http example.com
opensnitch
/littlesnitch
(links above) to view request topackages.httpie.io
Current result
Unnecessary/excessive requests to
packages.httpie.io
.…
Expected result
No unnecessary/excessive requests to
packages.httpie.io
.…
Debug output
Please re-run the command with
--debug
, then copy the entire command & output and paste both below:Additional information, screenshots, or code examples
…
The text was updated successfully, but these errors were encountered: