Use Timeout.timeout for TCP connection #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng timeouts in pure Ruby
|
@httprb/owners fyi if someone can 👍 quickly |
| else fail ArgumentError, "unsupported address class: #{addr.class}" | ||
| def connect_ssl | ||
| socket.connect_nonblock | ||
| rescue IO::WaitReadable |
There was a problem hiding this comment.
I guess I missed this on the last pass, but as the SSL/TLS handshake makes many roundtrips, I believe it's possible for IO::WaitWritable to be raised here too.
There was a problem hiding this comment.
Oops I broke Excon then!!
Sent from my iPhone
On Mar 31, 2015, at 08:40, Tony Arcieri notifications@github.com wrote:
In lib/http/timeout/per_operation.rb:
case addrwhen Resolv::IPv4family = Socket::AF_INETwhen Resolv::IPv6family = Socket::AF_INET6else fail ArgumentError, "unsupported address class: #{addr.class}"def connect_sslsocket.connect_nonblockrescue IO::WaitReadable—
Reply to this email directly or view it on GitHub.
|
This looks fine to me |
|
👍 from me as well :D |
sferik
added a commit
that referenced
this pull request
Mar 31, 2015
Use Timeout.timeout for TCP connection
zanker
pushed a commit
that referenced
this pull request
Apr 4, 2015
ixti
pushed a commit
that referenced
this pull request
Apr 6, 2015
zanker
pushed a commit
to zanker/http.rb
that referenced
this pull request
May 8, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, getting a pure solution to timeouts is essentially impossible without rewriting the entire stack yourself. Which I might actually do for fun later, but for the time being. This is the simplest way of getting a connect timeout :(