-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide implementation details #271
Conversation
Also added a HTTP::UnexpectedError which can be used to indicate that something went wrong.
@zanker @tarcieri personally I have no strong feelings one way or the other, so it's up to you guys if we want this PR to be merged in or not. This is a breaking changes so if we want this to be in - we should do this like now. |
👍 |
I'm a fan, but I'm concerned about breaking changes. Can we leave this for a 2.0? Sent from my iPhone
|
IMHO, if we all agree this is better, we should make this change now, before 1.0 is released, rather than kicking the can down the road and causing breakages in the future when (presumably, if everything goes according to plan) this library has even more users. |
Whoops, I forgot we only had a pre not an actual 1.0. I'm good with making the change now then. |
This looks good to me, although requires a bit of @zanker and yep, we're just at |
This is renewed #261