Skip to content

Fix corner case with Apache HTTP client v4 + RestEasy. #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

davidhsv
Copy link
Contributor

@davidhsv davidhsv commented Aug 1, 2022

Fix Apache Http Client interception bug when creating an anonymous class of SSLConnectionSocketFactory. When creating an anonymous class getDeclaredField will not return the needed socketFactory attribute. This is the behavior of RestEasy for some cases, see https://github.com/resteasy/Resteasy/blob/main/resteasy-client/src/main/java/org/jboss/resteasy/client/jaxrs/engines/ClientHttpEngineBuilder43.java#L128

Fix #2

@CLAassistant
Copy link

CLAassistant commented Aug 1, 2022

CLA assistant check
All committers have signed the CLA.

@davidhsv davidhsv force-pushed the fix-rest-easy-with-apache-httpclient branch 3 times, most recently from f6c5d08 to d8a939f Compare August 1, 2022 00:19
…ass of SSLConnectionSocketFactory. When creating an anonymous class getDeclaredField will not return the needed socketFactory attribute. This is the behavior of RestEasy for some cases, see https://github.com/resteasy/Resteasy/blob/main/resteasy-client/src/main/java/org/jboss/resteasy/client/jaxrs/engines/ClientHttpEngineBuilder43.java#L128
@davidhsv davidhsv force-pushed the fix-rest-easy-with-apache-httpclient branch from d8a939f to fb3a969 Compare August 1, 2022 00:27
@pimterry pimterry merged commit d574f95 into httptoolkit:main Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apache HttpClient interception setup failed
3 participants