Skip to content

GitHub Actions #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 11, 2021
Merged

GitHub Actions #27

merged 7 commits into from
Jun 11, 2021

Conversation

spautz
Copy link
Contributor

@spautz spautz commented Jun 10, 2021

This is intended to address #26

I tried to follow the same general patterns used in the other httptoolkit repos, where applicable. (Relatedly, I found what might be a typo in one of the other projects: https://github.com/httptoolkit/mockttp/blob/master/.github/workflows/ci.yml#L24 looks for node 14.6 but that's no longer in the matrix of versions.)

It currently only deploys Storybook from the master branch, as before, but an earlier build is still up from my fork:

@pimterry pimterry merged commit 7cba832 into httptoolkit:master Jun 11, 2021
@pimterry
Copy link
Member

Looks great to me, merged! And good catch on the Mockttp typo. I updated the matrix version there recently and clearly missed the other part 😃.

Thanks for all your help. It's not super related to this repo, but let me know if you want a free HTTP Toolkit Pro account - it's primarily a paid product, but it's completely free for contributors to anything in this org. Let me know if you're interested and I'll set one up for spautz@gmail.com (from your github bio).

@spautz spautz deleted the github-actions branch June 12, 2021 22:19
@spautz
Copy link
Contributor Author

spautz commented Jun 12, 2021

That would be great, if it's no trouble! I haven't actually tried out HTTP Toolkit yet, despite seeing it and using react-reverse-portal on its own. I'll check it out.

@pimterry
Copy link
Member

Sure, done! Just install the app from httptoolkit.tech, click 'Get Pro' in the bottom left, then 'Log into existing account' to log in with spautz@gmail.com. Thanks for all your help on this project so far!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants