Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"idle"->"closed" transition #991

Merged
merged 1 commit into from
Nov 29, 2021
Merged

Conversation

martinthomson
Copy link
Collaborator

I improved the text along the lines Jörg suggested. However, I realized
that the transition should really be in the diagram. That's basically
impossible given the nature of the diagram, but it's worth including in
the description at least.

For #990.

Copy link
Collaborator

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good clarification. One note about a whitespace change but the textual changes are 👍

</front>
</reference>
</front>
</reference>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this whitespace change intentional?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, my editor does a cleanup when I close it, and I caught this. I made the change on the main branch, so this is redundant (and wrong).

I improved the text along the lines Jörg suggested.  However, I realized
that the transition should really be in the diagram.  That's basically
impossible given the nature of the diagram, but it's worth including in
the description at least.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants