Skip to content
This repository was archived by the owner on Aug 31, 2021. It is now read-only.

Conversation

edisonxiang
Copy link
Contributor

What this PR does / why we need it: add nics for networking

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@edisonxiang edisonxiang force-pushed the addnic branch 9 times, most recently from dde73c4 to 5bbda89 Compare March 20, 2018 12:19
@coveralls
Copy link

coveralls commented Mar 20, 2018

Pull Request Test Coverage Report for Build 49

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 62.229%

Totals Coverage Status
Change from base Build 36: 0.0%
Covered Lines: 2412
Relevant Lines: 3876

💛 - Coveralls

}

// NicDisassociateOpts is a struct for disassociate
type NicDisassociateOpts struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty struct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks your review

@edisonxiang
Copy link
Contributor Author

Use Networking Port to implement vip features So close this pr.
If if it is used in future, it could be reopen.

@edisonxiang edisonxiang deleted the addnic branch June 14, 2018 09:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants