This repository was archived by the owner on Aug 31, 2021. It is now read-only.
add vpc, subnet, route and peering connection interfaces #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freesky-edward
suggested changes
Mar 28, 2018
| "github.com/huaweicloud/golangsdk/acceptance/clients" | ||
| "github.com/huaweicloud/golangsdk/acceptance/tools" | ||
| "github.com/huaweicloud/golangsdk/openstack/networking/v1/subnets" | ||
| "testing" |
There was a problem hiding this comment.
format the import order, it should be :
import (
"testing"
"github.com/huaweicloud/golangsdk"
"github.com/huaweicloud/golangsdk/openstack/networking/v2/peerings"
"github.com/huaweicloud/golangsdk/openstack/networking/v2/routes"
)
| "github.com/huaweicloud/golangsdk/acceptance/clients" | ||
| "github.com/huaweicloud/golangsdk/acceptance/tools" | ||
| "github.com/huaweicloud/golangsdk/openstack/networking/v1/vpcs" | ||
| "testing" |
There was a problem hiding this comment.
fix the order issue the same as above
| "github.com/huaweicloud/golangsdk/acceptance/tools" | ||
| "github.com/huaweicloud/golangsdk/openstack/networking/v1/vpcs" | ||
| "github.com/huaweicloud/golangsdk/openstack/networking/v2/peerings" | ||
| "testing" |
| "github.com/huaweicloud/golangsdk/acceptance/clients" | ||
| "github.com/huaweicloud/golangsdk/acceptance/tools" | ||
| "github.com/huaweicloud/golangsdk/openstack/networking/v2/peerings" | ||
| "testing" |
Pull Request Test Coverage Report for Build 58
💛 - Coveralls |
niuzhenguo
reviewed
Mar 29, 2018
| @@ -0,0 +1,57 @@ | |||
| /* | |||
| Package Subnets enables management and retrieval of Subnets from the Open Telekom Cloud VPC service. | |||
There was a problem hiding this comment.
Nits: not only Open Telekom Cloud uses this golangsdk, better to not mention it here.
openstack/networking/v1/vpcs/doc.go
Outdated
| @@ -0,0 +1,52 @@ | |||
| /* | |||
| Package vpcs enables management and retrieval of Vpcs from the Open Telekom Cloud | |||
| @@ -0,0 +1,87 @@ | |||
| /* | |||
| Package peerings enables management and retrieval of vpc peering connections from the Open Telekom Cloud VPC service. | |||
|
|
|||
| if matched { | ||
| refinedPeerings = append(refinedPeerings, peering) | ||
| } | ||
| }*/ |
| return c.ServiceURL(rootPath, resourcePath, id) | ||
| } | ||
|
|
||
| func deleteURL(c *golangsdk.ServiceClient, id string) string { |
There was a problem hiding this comment.
seems there's no difference between deleteURL and resourceURL, how about just using one resourceURL?
|
@niuzhenguo Updated comments and removed redundant code. Let me know if there is more feedback. |
|
@Savasw Thanks for the update, LGTM now! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: This PR adds VPC, Subnet, Route, and Peering Connection interfaces
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #4Special notes for your reviewer: The acceptance tests for peering connection and routes require Peer's tenant id or name (OS_Peer_Tenant_ID or OS_Peer_Tenant_Name), hence acceptance tests for these two interfaces fail if peer tenant details not provided. Also they required Peer Network Client separately, hence two new client functions are part of acceptance clients.go file where Peer tenant id is validated individually with no impact on other modules.
Release note: