Add IAM apis into the project #13
Conversation
Pull Request Test Coverage Report for Build 99
💛 - Coveralls |
|
|
||
| // Extra is a collection of miscellaneous key/values. | ||
| Extra map[string]interface{} `json:"-"` | ||
| Extra map[string]interface{} `json:"-,omitempty"` |
There was a problem hiding this comment.
if the field tag is "-", the field is always omitted, I am not sure the purpose of this change. could you please check whether is it a maloperation.
openstack/client.go
Outdated
| // object storage package. | ||
| func NewObjectStorageV1(client *golangsdk.ProviderClient, eo golangsdk.EndpointOpts) (*golangsdk.ServiceClient, error) { | ||
| return initClientOpts(client, eo, "object-store") | ||
| return initClientOpts(client, eo, "object") |
There was a problem hiding this comment.
object-store is quite different from object. one is a service of swift service, another is OBS service. does this propose to remove swift support? if so, I suggest to change one other method name.
There was a problem hiding this comment.
Use "object-store" will cause "No suitable endpoint could be found in the service catalog." in acceptance tests. I don't know if the resources is currently not published?
There was a problem hiding this comment.
that may cause by the service unavailable. I recommend to leave this method as it was, comment it out or remove it util the service is available. in the meantime, it would be much better to add a new method when you are going to support object service.
There was a problem hiding this comment.
Sure, I will make another commit
roles.CheckRoleOf to check if the role existed in a special target roles.ListRolesOf to list roles of special target
|
@sillydong Hi, Thanks for your effort. |
4 participants
This PR is adding IAM apis into the project:
**We have fixed the fixture and all pass. The acceptance still have few fail. According to ZhangDong, we keep it remaind. **: