Skip to content
This repository was archived by the owner on Aug 31, 2021. It is now read-only.

Conversation

xioxu
Copy link
Collaborator

@xioxu xioxu commented Apr 20, 2018

…ice.

case 1:
'cdn,dns' use same address for all locale
case 2:
other non existing service will use an valid service endpoint url through replace its service name. e,g: https://vpn.cn-bj.huawei.com -> https://none.cn-bj.huawei.com

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

…ice.

case 1:
  'cdn,dns' use same address for all locale
case 2:
  other non existing service will use an valid service endpoint url through replace its service name. e,g: https://vpn.cn-bj.huawei.com   -> https://none.cn-bj.huawei.com
@xioxu xioxu closed this Apr 20, 2018
@xioxu xioxu reopened this Apr 20, 2018
@coveralls
Copy link

coveralls commented Apr 20, 2018

Pull Request Test Coverage Report for Build 88

  • 51 of 53 (96.23%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 66.041%

Changes Missing Coverage Covered Lines Changed/Added Lines %
openstack/endpoint_location.go 51 53 96.23%
Files with Coverage Reduction New Missed Lines %
openstack/endpoint_location.go 4 93.94%
Totals Coverage Status
Change from base Build 86: 0.2%
Covered Lines: 3061
Relevant Lines: 4635

💛 - Coveralls

@xioxu xioxu closed this Apr 20, 2018
@freesky-edward freesky-edward added the enhancement New feature or request label Apr 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants