Skip to content
This repository was archived by the owner on Aug 31, 2021. It is now read-only.

Conversation

xioxu
Copy link
Collaborator

@xioxu xioxu commented Apr 21, 2018

What this PR does / why we need it:

  1. (KMS)Customized key management
  2. (KMS)Crypto methods

Release note:

xioxu added 4 commits April 20, 2018 16:20
…ice.

case 1:
  'cdn,dns' use same address for all locale
case 2:
  other non existing service will use an valid service endpoint url through replace its service name. e,g: https://vpn.cn-bj.huawei.com   -> https://none.cn-bj.huawei.com
@coveralls
Copy link

coveralls commented Apr 21, 2018

Pull Request Test Coverage Report for Build 90

  • 341 of 541 (63.03%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 65.569%

Changes Missing Coverage Covered Lines Changed/Added Lines %
openstack/client.go 0 1 0.0%
openstack/kms/v1/cmk/url.go 33 48 68.75%
openstack/kms/v1/cmk/results.go 59 84 70.24%
openstack/kms/v1/crypto/requests.go 77 112 68.75%
openstack/kms/v1/cmk/requests.go 116 240 48.33%
Totals Coverage Status
Change from base Build 86: -0.3%
Covered Lines: 3365
Relevant Lines: 5132

💛 - Coveralls

@xioxu xioxu closed this Apr 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants