Skip to content
This repository was archived by the owner on Aug 31, 2021. It is now read-only.

Conversation

xioxu
Copy link
Collaborator

@xioxu xioxu commented Apr 21, 2018

What this PR does / why we need it:

  • Handle the situation that the service endpoint is not existing in IAM response

Which issue this PR fixes
NONE

Special notes for your reviewer:
To work with the service which its endpoint is not in IAM response data(e,g: AntiDDoS), we have to change the endpoint_location method make it works as expected.

Release note:
NONE

xioxu added 7 commits April 20, 2018 16:20
…ice.

case 1:
  'cdn,dns' use same address for all locale
case 2:
  other non existing service will use an valid service endpoint url through replace its service name. e,g: https://vpn.cn-bj.huawei.com   -> https://none.cn-bj.huawei.com
@coveralls
Copy link

coveralls commented Apr 21, 2018

Pull Request Test Coverage Report for Build 94

  • 407 of 553 (73.6%) changed or added relevant lines in 8 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.7%) to 66.556%

Changes Missing Coverage Covered Lines Changed/Added Lines %
openstack/client.go 0 1 0.0%
openstack/endpoint_location.go 62 68 91.18%
openstack/kms/v1/cmk/url.go 33 48 68.75%
openstack/kms/v1/cmk/results.go 59 84 70.24%
openstack/kms/v1/crypto/requests.go 77 112 68.75%
openstack/kms/v1/cmk/requests.go 120 184 65.22%
Files with Coverage Reduction New Missed Lines %
openstack/endpoint_location.go 4 91.23%
Totals Coverage Status
Change from base Build 86: 0.7%
Covered Lines: 3417
Relevant Lines: 5134

💛 - Coveralls

@xioxu xioxu closed this Apr 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants