Compute #27
Compute #27
Conversation
acceptance/clients/clients.go
Outdated
|
|
||
| "github.com/huaweicloud/golangsdk" | ||
| "github.com/huaweicloud/golangsdk/openstack" | ||
| "net/http" |
There was a problem hiding this comment.
please fix the failed format check
| "github.com/huaweicloud/golangsdk" | ||
| "github.com/huaweicloud/golangsdk/acceptance/clients" | ||
| "github.com/huaweicloud/golangsdk/acceptance/tools" | ||
| //"github.com/gophercloud/gophercloud/openstack/blockstorage/v2/volumes" |
There was a problem hiding this comment.
there are many lines commented out, I am not sure I understand completely. but it would be better removing them away.
|
|
||
| /* | ||
| func TestFlavorsCreateDelete(t *testing.T) { | ||
| clients.RequireAdmin(t) |
There was a problem hiding this comment.
the original openstack have these apis, but according to the task document and huawei api document, these functions are not used. We commented it in case that one day you may need them. Should I delete them or leave them there?
There was a problem hiding this comment.
@liyongle I think that would be a question which you can give the right suggestion.
IMHO, if they are all from original repository, we should keep them as they were. especially the copy-right.
|
BTW, please rebase your branch to the newest version before checking CI issue. |
Pull Request Test Coverage Report for Build 104
💛 - Coveralls |
…12, 6.21, 6.22, 16.1, 16.2
|
LGTM |
4 participants
This PR is add ECS api into the project:
We use compute directory to keep ECS apis. This includes the apis from OpenStack.
All unit tests have passed. Acceptances have few error cause some resource can not be requested.
We'll mail detail to ZhangDong later.