This repository was archived by the owner on Aug 31, 2021. It is now read-only.
Add SFS interfaces #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niuzhenguo
reviewed
Jul 4, 2018
openstack/client.go
Outdated
| return sc, err | ||
| } | ||
|
|
||
| //NewSFSV2 creates a service client taht is used for Huawei cloud for SFS , it replaces the EVS type. |
| //NewSFSV2 creates a service client taht is used for Huawei cloud for SFS , it replaces the EVS type. | ||
| func NewHwSFSV2(client *golangsdk.ProviderClient, eo golangsdk.EndpointOpts) (*golangsdk.ServiceClient, error) { | ||
| sc, err := initClientOpts(client, eo, "evs") | ||
| sc.Endpoint = strings.Replace(sc.Endpoint, "evs", "sfs", 1) |
There was a problem hiding this comment.
better to leave a TODO here to use real service type when we add the endpoint for SFS.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: This PR adds SFS interfaces
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:NONE
Release note:NONE