This repository was archived by the owner on Aug 31, 2021. It is now read-only.
Add DeH service interfaces #39
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 158
💛 - Coveralls |
| func NewDCSServiceV1(client *golangsdk.ProviderClient, eo golangsdk.EndpointOpts) (*golangsdk.ServiceClient, error) { | ||
| sc, err := initClientOpts(client, eo, "network") | ||
| sc.Endpoint = strings.Replace(sc.Endpoint, "vpc", "dcs", 1) | ||
| sc.ResourceBase = sc.Endpoint + "v1.0/" + client.ProjectID + "/" |
There was a problem hiding this comment.
I am not sure whether this change can work well or not. that will require this service endpoint is registered into catalog on all clouds. @edisonxiang could you please check this?
There was a problem hiding this comment.
@disha-wani @freesky-edward Currently huawei cloud has no endpoint about dms and dcs.
So please keep these codes, because the following codes will not work.
sc, err := initClientOpts(client, eo, "dms")
sc, err := initClientOpts(client, eo, "dcs")
openstack/deh/v1/hosts/results.go
Outdated
| Cores int `json:"cores"` | ||
| Sockets int `json:"sockets"` | ||
| Memory int `json:"memory"` | ||
| AvailableInstanceCapacities []AvailableInstanceCapacitiesOpts `json:"available_instance_capacities"` |
There was a problem hiding this comment.
can shorten the words?
openstack/client.go
Outdated
|
|
||
| // NewDeHServiceV1 creates a ServiceClient that may be used to access the v1 Dedicated Hosts service. | ||
| func NewDeHServiceV1(client *golangsdk.ProviderClient, eo golangsdk.EndpointOpts) (*golangsdk.ServiceClient, error) { | ||
| func NewDeHOTCServiceV1(client *golangsdk.ProviderClient, eo golangsdk.EndpointOpts) (*golangsdk.ServiceClient, error) { |
There was a problem hiding this comment.
I think there should be something misunderstanding here. as you may know, now there are several clouds with only one SDK repo, so we would prefer not to define any specific method here
| func NewDCSServiceV1(client *golangsdk.ProviderClient, eo golangsdk.EndpointOpts) (*golangsdk.ServiceClient, error) { | ||
| sc, err := initClientOpts(client, eo, "network") | ||
| sc.Endpoint = strings.Replace(sc.Endpoint, "vpc", "dcs", 1) | ||
| sc.ResourceBase = sc.Endpoint + "v1.0/" + client.ProjectID + "/" |
|
Closing this PR due to bad commits |
1 similar comment
|
Closing this PR due to bad commits |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: This PR adds Dedicated Host interfaces
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:NONE
Release note:NONE