Skip to content
This repository was archived by the owner on Aug 31, 2021. It is now read-only.

Conversation

Savasw
Copy link
Contributor

@Savasw Savasw commented Jul 12, 2018

What this PR does / why we need it: This PR adds DeH service interfaces

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:None

Release note: None

@coveralls
Copy link

coveralls commented Jul 12, 2018

Pull Request Test Coverage Report for Build 161

  • 121 of 164 (73.78%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 65.818%

Changes Missing Coverage Covered Lines Changed/Added Lines %
openstack/client.go 0 4 0.0%
openstack/deh/v1/hosts/results.go 48 52 92.31%
openstack/deh/v1/hosts/requests.go 64 99 64.65%
Totals Coverage Status
Change from base Build 156: 0.3%
Covered Lines: 3335
Relevant Lines: 5067

💛 - Coveralls

@freesky-edward
Copy link
Contributor

LGTM

@freesky-edward freesky-edward merged commit 633b0dc into huaweicloud:master Jul 13, 2018
@simrannagra simrannagra deleted the deh-merge branch August 6, 2018 06:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants