Skip to content
This repository was archived by the owner on Aug 31, 2021. It is now read-only.

Conversation

Savasw
Copy link
Contributor

@Savasw Savasw commented Jul 22, 2018

What this PR does / why we need it: This PR adds CCE service interfaces

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:NONE

Release note:NONE

@coveralls
Copy link

coveralls commented Jul 22, 2018

Pull Request Test Coverage Report for Build 175

  • 180 of 237 (75.95%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 63.314%

Changes Missing Coverage Covered Lines Changed/Added Lines %
openstack/cce/v3/nodes/results.go 15 17 88.24%
openstack/cce/v3/clusters/results.go 10 12 83.33%
openstack/cce/v3/nodes/requests.go 81 98 82.65%
openstack/cce/v3/clusters/requests.go 59 95 62.11%
Totals Coverage Status
Change from base Build 173: 0.3%
Covered Lines: 3978
Relevant Lines: 6283

💛 - Coveralls

Copy link
Contributor

@freesky-edward freesky-edward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one comment is it is not necessary to add okcodes definition if the ok code is default.

@freesky-edward freesky-edward merged commit f3e5581 into huaweicloud:master Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants