Skip to content
This repository was archived by the owner on Aug 31, 2021. It is now read-only.

Conversation

Savasw
Copy link
Contributor

@Savasw Savasw commented Sep 20, 2018

What this PR does / why we need it:This PR adds snapshot id parameter for volume metadata in response and Huawei client for csbs

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@coveralls
Copy link

Pull Request Test Coverage Report for Build 225

  • 0 of 8 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 69.689%

Changes Missing Coverage Covered Lines Changed/Added Lines %
openstack/client.go 0 8 0.0%
Totals Coverage Status
Change from base Build 220: -0.03%
Covered Lines: 11252
Relevant Lines: 16146

💛 - Coveralls

@coveralls
Copy link

coveralls commented Sep 20, 2018

Pull Request Test Coverage Report for Build 233

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.155%

Totals Coverage Status
Change from base Build 232: 0.0%
Covered Lines: 5445
Relevant Lines: 7245

💛 - Coveralls

@zengchen1024
Copy link
Contributor

please fix the conficting first. then I will merge it. Thanks

@Savasw
Copy link
Contributor Author

Savasw commented Sep 26, 2018

@zengchen1024 Done

@zengchen1024 zengchen1024 merged commit f5988f6 into huaweicloud:master Sep 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants