Skip to content
This repository was archived by the owner on Aug 31, 2021. It is now read-only.

Conversation

ninja-vlogs
Copy link
Contributor

@ninja-vlogs ninja-vlogs commented Nov 20, 2018

What this PR does / why we need it: In OTC Cloud, CCE Get and List cluster API response has endpoints field as a single object and in HW Cloud, the endpoints field is list of objects, so this PR handles that.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer: The OTC CCE terraform is dependent on this PR.

Release note:

NONE

In OTC Cloud,cce Get and List cluster Endpoints field require struct type but not list of struct type ,contrary to other clouds, so this commit handles that.
@coveralls
Copy link

coveralls commented Nov 20, 2018

Pull Request Test Coverage Report for Build 280

  • 27 of 31 (87.1%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 69.463%

Changes Missing Coverage Covered Lines Changed/Added Lines %
openstack/cce/v3/clusters/results.go 27 31 87.1%
Totals Coverage Status
Change from base Build 278: 0.03%
Covered Lines: 11776
Relevant Lines: 16953

💛 - Coveralls

Copy link
Contributor

@freesky-edward freesky-edward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@freesky-edward freesky-edward merged commit 02e7852 into huaweicloud:master Nov 21, 2018
@Savasw Savasw deleted the cce_otccloud_fix branch November 30, 2018 07:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants