Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRUD repository variable #1675

Merged
merged 18 commits into from
Jun 12, 2023
Merged

CRUD repository variable #1675

merged 18 commits into from
Jun 12, 2023

Conversation

garridobarrera
Copy link
Contributor

@garridobarrera garridobarrera commented Jun 9, 2023

Description

Methods to create and update repository variables:

Before submitting a PR:

  • Changes must not break binary backwards compatibility. If you are unclear on how to make the change you think is needed while maintaining backward compatibility, CONTRIBUTING.md for details.
  • Add JavaDocs and other comments as appropriate. Consider including links in comments to relevant documentation on https://docs.github.com/en/rest .
  • Add tests that cover any added or changed code. This generally requires capturing snapshot test data. See CONTRIBUTING.md for details.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.
  • Push your changes to a branch other than main. You will create your PR from that branch.

When creating a PR:

  • Fill in the "Description" above with clear summary of the changes. This includes:
    • If this PR fixes one or more issues, include "Fixes #" lines for each issue.
    • Provide links to relevant documentation on https://docs.github.com/en/rest where possible.
  • All lines of new code should be covered by tests as reported by code coverage. Any lines that are not covered must have PR comments explaining why they cannot be covered. For example, "Reaching this particular exception is hard and is not a particular common scenario."
  • Enable "Allow edits from maintainers".

@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Patch coverage: 88.23% and project coverage change: +0.04 🎉

Comparison is base (406fc7e) 79.93% compared to head (87e6fae) 79.97%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1675      +/-   ##
============================================
+ Coverage     79.93%   79.97%   +0.04%     
- Complexity     2208     2221      +13     
============================================
  Files           212      213       +1     
  Lines          6688     6718      +30     
  Branches        364      365       +1     
============================================
+ Hits           5346     5373      +27     
- Misses         1128     1131       +3     
  Partials        214      214              
Impacted Files Coverage Δ
.../java/org/kohsuke/github/GHRepositoryVariable.java 84.00% <82.60%> (+17.33%) ⬆️
src/main/java/org/kohsuke/github/GHRepository.java 71.76% <100.00%> (+0.04%) ⬆️
...rg/kohsuke/github/GHRepositoryVariableBuilder.java 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@garridobarrera garridobarrera marked this pull request as ready for review June 9, 2023 07:18
@garridobarrera
Copy link
Contributor Author

@bitwiseman I had a problem with this PR #1668 and close it by error so i have opened this one.

Copy link
Member

@bitwiseman bitwiseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@garridobarrera
Great work! Thanks!

I made some minor tweaks. Will merge when CI passes.

@bitwiseman bitwiseman merged commit 8b80485 into hub4j:main Jun 12, 2023
@dougj-contrast
Copy link

Hello @bitwiseman is there a process or request that can be made to get this change rolled into a new release? We would like to take advantage of this new feature, but noticed it was merged after the last release cut 06/01.

Please advise or let me know if we should open an issue requesting a new release, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants