1.2.9 #790
Merged
1.2.9 #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
katat
commented
Oct 25, 2019
katat
commented
- Add script for notarizing mac version
- Increase the default gas limit for nahmii deposit
jonbern
approved these changes
Oct 25, 2019
| appleIdPassword: process.env.APPLE_ID_PASSWORD, | ||
| }); | ||
| } catch (error) { | ||
| console.error(error); |
There was a problem hiding this comment.
Does it make sense to catch this error and continue? Should the build succeed if we are not able to notarize the app? Or is this intentional, in mitigating the current long processing time of notarizations?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.