WIP: Add first iteration of revised trade types lib #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morfj
reviewed
Jun 20, 2019
jonbern
reviewed
Jun 20, 2019
morfj
reviewed
Jun 21, 2019
morfj
reviewed
Jun 21, 2019
jijordre
changed the title
jijordre
force-pushed
the
feature/schemas-trade-1
branch
from
0a61a26
to
0c53a04
Compare
jijordre
force-pushed
the
feature/schemas-trade-1
branch
from
0c53a04
to
c53bdab
Compare
morfj
reviewed
Jul 19, 2019
| order.party.balances.conjugate | ||
| ); | ||
| const walletSignatureHash = exports.hashSignature(order.seals.wallet.signature); | ||
| return cryptography.hash(partyHash, walletSignatureHash); |
There was a problem hiding this comment.
Missing operator.data in hash?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution to #415.
File TradeTypesLib2.sol was added. Eventually the old schemas in TradeTypesLib.sol will be replaced by the ones in the new file.
One question to keep at the back of your head when reviewing. Struct
OrderPartyhas propertybalances, so will contain one balance amount value for each of intended and conjugate currencies. We should ask ourselves whether this should be expanded to current and previous balances for each of the two currencies, thus a total of 4 balance values for the order party.This iteration keeps
Trade.transfersfor now. This property, however, is likely to be deemed obsolete at the end of updates of DSC and NSC logics (#418).Also order cancellation should be taken with a huge pile of salt and its more thorough definition deferred to #419.