Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify definitions for barcode size and offset #83

Closed
cebriggs7135 opened this issue Mar 28, 2020 · 2 comments · Fixed by #86
Closed

Modify definitions for barcode size and offset #83

cebriggs7135 opened this issue Mar 28, 2020 · 2 comments · Fixed by #86

Comments

@cebriggs7135
Copy link
Contributor

cebriggs7135 commented Mar 28, 2020

cell_barcode_offset definition should read:
Positions in the read at which the cell barcodes start. Cell barcodes are 3 x 8 bp sequences that are spaced by constant sequences (the offsets). First barcode at position 0, then 38, then 76. (Does not apply to SNARE-seq and BulkATAC)

cell_barcode_size definition should read:
Length of the cell barcode in base pairs. Cell barcodes are, for example, 3 x 8 bp sequences that are spaced by constant sequences, the offsets. (Does not apply to SNARE-seq and BulkATAC)

@cebriggs7135 cebriggs7135 changed the title Modify definitions for barcode offset size and offset Modify definitions for barcode size and offset Mar 28, 2020
@mccalluc
Copy link
Contributor

Will do. For copy-edits, you can also submit PRs, and that might be more direct.

@mccalluc
Copy link
Contributor

First barcode at position 0, then 38, then 76.

If that is an example of a value, perhaps rephrase to make that more clear?

mccalluc added a commit that referenced this issue Mar 30, 2020
mccalluc added a commit that referenced this issue Mar 30, 2020
* Placeholder

* DOIs optional; directory schema for atacseq

* Make the barcode fields triples

* changelog

* Fix #83

* Fix #85
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants