Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v3.2.1- Bug Fixes #73

Closed
wants to merge 1 commit into from
Closed

v3.2.1- Bug Fixes #73

wants to merge 1 commit into from

Conversation

robhruska
Copy link
Member

Release Notes

  • Add locking around _observers list in MjolnirConfiguration to prevent a possible race condition that results in IndexOutOfRangeExceptions when adding to the list of subscribers.

lewislabs
lewislabs approved these changes Aug 24, 2018
View reviewed changes
Copy link
Contributor

@lewislabs lewislabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks sensible to me. I can see how the missing lock could result in a concurrent modification of the list of observers, and therefore the IndexOutOfRangeExceptions we're seeing.

A CHANGELOG entry is missing here but otherwise :shipit:

@robhruska
Copy link
Member Author

No CHANGELOG.md in this repo, they end up in the tagged Release.

@robhruska
Copy link
Member Author

Fixed with #74

@robhruska robhruska closed this Oct 26, 2018
@robhruska robhruska deleted the PreventRaceCondition branch October 26, 2018 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lewislabs lewislabs lewislabs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robhruska @lewislabs