Replace non threaded safe List with a ConcurrentDictionary in bulkhead factory. #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
factory. That will eliminate race condition while creating bulkheads.
robhruska
reviewed
Oct 26, 2018
|
|
||
| private readonly ConcurrentDictionary<IObserver<MjolnirConfiguration>, IObserver<MjolnirConfiguration>> | ||
| _observers = new ConcurrentDictionary<IObserver<MjolnirConfiguration>, IObserver<MjolnirConfiguration>>(); | ||
|
|
There was a problem hiding this comment.
Is there a better option than using the observer as both the key and the value? Not that I think this is wrong, just curious on alternatives.
There was a problem hiding this comment.
Joining the party a bit late but it seems like a ConcurrentBag would suffice here, seeing as you just add/remove.
|
This needs tagged as a Release. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A List is not thread-safe. This PR is changing bulkheads subscriptions to a thread-safe concurrent dictionary.
That will eliminate race condition while creating bulkheads.