Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new section structure #102

Merged

Conversation

MoritzLaurer
Copy link
Collaborator

What does this PR do?

draft PR for testing new section structure discussed internally here

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@MoritzLaurer MoritzLaurer marked this pull request as ready for review May 30, 2024 10:08
@MoritzLaurer
Copy link
Collaborator Author

PR is ready for review @stevhliu.
I'm not sure how to rename the overall documentation page to "Hugging Face Cookbook" (screenshot).
Screenshot 2024-05-30 at 12 05 55

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

I'm not sure how to rename the overall documentation page to "Hugging Face Cookbook" (screenshot).

I think you'll have to change it here in the title field.

It may also be a good idea to update the description to include something about the Enterprise Hub or make it more general and not just "open-source".

Also cc'ing @merveenoyan for any feedback about the new structure since this would be a pretty big change 🙂

notebooks/en/_toctree.yml Outdated Show resolved Hide resolved
@MoritzLaurer
Copy link
Collaborator Author

I've opened this internal PR to update the name and description of the cookbook.

The present PR should be ready to be merged from my side @stevhliu @merveenoyan

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reorganizing everything!

@stevhliu stevhliu merged commit 06dfb2a into huggingface:main Jun 5, 2024
1 check passed
@MoritzLaurer MoritzLaurer deleted the reorganize-cookbook-structure branch June 17, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants