New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove os.environ.copy in Dataset.map #2118

Closed

mariosasko wants to merge 1 commit into huggingface:master from mariosasko:fix-copy-env

Collaborator

mariosasko commented Mar 26, 2021

Replace os.environ.copy with in-place modification
Fixes #2115


          Remove os.environ.copy in Dataset.map

85567e8

Collaborator Author

mariosasko commented Mar 26, 2021

I thought deepcopy on os.environ is unsafe (see this), but I can't replicate the behavior described in the linked SO thread.

Closing this one because #2119 has a much cleaner approach.

mariosasko closed this

mariosasko deleted the fix-copy-env branch

March 26, 2021 12:03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet