Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Units 1 and 6: Fix for installing notebook dependencies #252

Merged
merged 2 commits into from
Mar 23, 2023

Conversation

AnotherPianist
Copy link
Contributor

@AnotherPianist AnotherPianist commented Mar 22, 2023

Fixes #251, #253, and #255.

Currently, this notebook can't be run because of an error while installing the dependencies.

The error comes from trying to install the stable-baselines3 package. They are aware of this bug and working on it for the next version. Their current workaround is to use the 65.5.0 version of setuptools by running pip install setuptools==65.5.0. For more information, see DLR-RM/stable-baselines3#1324.

Adding the line setuptools==65.5.0 at the top of the requirements-unit6.txt file doesn't solve the problem since pip doesn't have a way to install packages in order (see pypa/pip#2362).

Therefore, the solution is to add a new code cell to the notebook to run pip install setuptools==65.5.0 before installing requirements-unit6.txt.

@AnotherPianist
Copy link
Contributor Author

AnotherPianist commented Mar 23, 2023

The same issue is happening in the notebook from Unit 1.

As a solution, the same code cell is added to notebook 1.

Fixes #253 and #255.

@AnotherPianist AnotherPianist changed the title Unit 6: Fix for installing notebook dependencies Units 1 and 6: Fix for installing notebook dependencies Mar 23, 2023
@nikohou
Copy link

nikohou commented Mar 23, 2023

This helped thanks!

Copy link
Contributor

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving and merging so things are not broken in the incoming days

@osanseviero osanseviero merged commit f14c53f into huggingface:main Mar 23, 2023
@osanseviero
Copy link
Contributor

Thanks a lot for this fix!! 🔥

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit 6: Failed to install dependencies
5 participants