-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo in rouge types #364
Conversation
The name of the variable inside elif rouge_type == "rougeLsum": So I think we should leave it as it was. Why did you want to change it? |
The doc state otherwise. Whatever name you want to use, it is just not uniformized.
|
Ok I see, then let's go with the lower-case version since that's follows the code. |
Updated. P.S. I feel like rouseLsum is an odd writing style ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks good! Note that this is not our convention but the follows the underlying library (rouge_score
from Google Research).
This reverts commit 57fe685.
Minor typo fix in the code and doc example that does not align with the writing style (rougeLsum -> rougeLSum).