-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add GitHub Actions CI #375
Conversation
The documentation is not available anymore as the PR was closed or merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't check the test changes, but the new CI job looks all good :)
@@ -205,6 +240,7 @@ def test_pipe_init(self): | |||
) | |||
self.assertEqual(results["accuracy"], 1.0) | |||
|
|||
@slow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when possible you can mock a model using a rule based function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's what we do for all the other tests, but I think we can keep a slow test that loads an actual model. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup for sure :)
Migrates the CircleCI CI to GitHub actions. It also addresses a few other issues:
transformers.Trainer
parity tests with theEvaluator
to a separate workflow (so they run in parallel and independent).slow
as they require loading large models that lead to OOM.The tests take now just 1-2min (+up to 3-5min for installing dependencies) compared to 15min+ before.