Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add GitHub Actions CI #375

Merged
merged 24 commits into from
Dec 7, 2022
Merged

add GitHub Actions CI #375

merged 24 commits into from
Dec 7, 2022

Conversation

lvwerra
Copy link
Member

@lvwerra lvwerra commented Dec 5, 2022

Migrates the CircleCI CI to GitHub actions. It also addresses a few other issues:

  • splits the transformers.Trainer parity tests with the Evaluator to a separate workflow (so they run in parallel and independent).
  • removed explicit model testing for the Evaluator wherever possible and test the main features only in the base tests.
  • moved some measurement tests to slow as they require loading large models that lead to OOM.

The tests take now just 1-2min (+up to 3-5min for installing dependencies) compared to 15min+ before.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Dec 5, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't check the test changes, but the new CI job looks all good :)

@@ -205,6 +240,7 @@ def test_pipe_init(self):
)
self.assertEqual(results["accuracy"], 1.0)

@slow
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when possible you can mock a model using a rule based function

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what we do for all the other tests, but I think we can keep a slow test that loads an actual model. What do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup for sure :)

@lvwerra lvwerra merged commit 27653b1 into main Dec 7, 2022
@lvwerra lvwerra deleted the migrate-ci branch December 7, 2022 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants